Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update kotlin version to 2.1.0 #230

Merged
merged 5 commits into from
Dec 20, 2024
Merged

Conversation

CaelmBleidd
Copy link
Member

No description provided.

@CaelmBleidd CaelmBleidd requested a review from Saloed December 20, 2024 14:42
override fun resolve(position: Position): Maybe<CommonValue> = when (position) {
This -> Maybe.some(getThisInstance(method))
override fun resolve(position: Position): Maybe<CommonValue> = with(traits) {
when (position) {

Check warning

Code scanning / detekt

Braces do not comply with the specified policy Warning

Inconsistent braces, make sure all branches either have or don't have braces.
override fun resolve(position: Position): Maybe<AccessPath> = when (position) {
This -> convertToPathOrNull(getThisInstance(method)).toMaybe()
override fun resolve(position: Position): Maybe<AccessPath> = with(traits) {
when (position) {

Check warning

Code scanning / detekt

Braces do not comply with the specified policy Warning

Inconsistent braces, make sure all branches either have or don't have braces.
if (config != null) {
val facts = mutableSetOf<Tainted>()
val conditionEvaluator = FactAwareConditionEvaluator(
traits, fact, CallPositionToValueResolver(traits, callStatement)

Check warning

Code scanning / detekt

Reports incorrect argument list wrapping Warning

Argument should be on a separate line (unless all arguments can fit a single line)
if (config != null) {
val facts = mutableSetOf<Tainted>()
val conditionEvaluator = FactAwareConditionEvaluator(
traits, fact, CallPositionToValueResolver(traits, callStatement)

Check warning

Code scanning / detekt

Reports incorrect argument list wrapping Warning

Argument should be on a separate line (unless all arguments can fit a single line)
Comment on lines +325 to +326
// the callee (when it is going to be analyzed), i.e. through "call-to-start" and
// "exit-to-return" flow functions.

Check warning

Code scanning / detekt

Reports methods that have an empty first line. Warning

First line in a method block should not be empty
if (deleteFrom.left == null) {
val succ = deleteFrom.succ()
checkNotNull(succ)
return removeRec(succ.value, deleteFrom.right) { k(deleteFrom.update(value = succ.value, right = it).balanceAfterRemove()) }

Check warning

Code scanning / detekt

Line detected, which is longer than the defined maximum line length in the code style. Warning

Line detected, which is longer than the defined maximum line length in the code style.
if (deleteFrom.left == null) {
val succ = deleteFrom.succ()
checkNotNull(succ)
return removeRec(succ.value, deleteFrom.right) { k(deleteFrom.update(value = succ.value, right = it).balanceAfterRemove()) }

Check warning

Code scanning / detekt

Reports missing newlines (e.g. between parentheses of a multi-line function call Warning

Missing newline after "{"

val pred = deleteFrom.pred()
checkNotNull(pred)
return removeRec(pred.value, deleteFrom.left) { k(deleteFrom.update(value = pred.value, left = it).balanceAfterRemove()) }

Check warning

Code scanning / detekt

Line detected, which is longer than the defined maximum line length in the code style. Warning

Line detected, which is longer than the defined maximum line length in the code style.

val pred = deleteFrom.pred()
checkNotNull(pred)
return removeRec(pred.value, deleteFrom.left) { k(deleteFrom.update(value = pred.value, left = it).balanceAfterRemove()) }

Check warning

Code scanning / detekt

Reports missing newlines (e.g. between parentheses of a multi-line function call Warning

Missing newline after "{"
@CaelmBleidd CaelmBleidd force-pushed the caelmbleidd/update_kotlin_version branch from 556fa95 to 703b36c Compare December 20, 2024 18:08
@CaelmBleidd CaelmBleidd merged commit 4014545 into main Dec 20, 2024
2 checks passed
@Lipen Lipen deleted the caelmbleidd/update_kotlin_version branch December 26, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants